[ 
https://issues.apache.org/jira/browse/FLINK-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963050#comment-14963050
 ] 

ASF GitHub Bot commented on FLINK-2731:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1233#discussion_r42351565
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/web/WebFrontendITCase.java ---
    @@ -110,21 +112,18 @@ public void getTaskmanagers() {
                }
        }
     
    -// TODO activate this test after logging retrieval has been added to the 
new web frontend
    -// @Test
    -// public void getLogfiles() {
    -//         try {
    -//                 String logPath = 
cluster.configuration().getString(ConfigConstants.JOB_MANAGER_WEB_LOG_PATH_KEY, 
null);
    -//                 Assert.assertNotNull(logPath);
    -//                 FileUtils.writeStringToFile(new File(logPath, 
"jobmanager-main.log"), "test content");
    -//
    -//                 String logs = 
getFromHTTP("http://localhost:8081/logInfo";);
    -//                 Assert.assertTrue(logs.contains("test content"));
    -//         }catch(Throwable e) {
    -//                 e.printStackTrace();
    -//                 Assert.fail(e.getMessage());
    -//         }
    -// }
    +   @Test
    +   public void getLogAndStdoutFiles() {
    +           try {
    +                   String logs = getFromHTTP("http://localhost:"; + port + 
"/jobmanager/log");
    +                   Assert.assertTrue(logs.contains("job manager log"));
    +                   logs = getFromHTTP("http://localhost:"; + port + 
"/jobmanager/stdout");
    +                   Assert.assertTrue(logs.contains("job manager out"));
    --- End diff --
    
    How about writing something to the log or stdout and checking for the 
result here?


> Add JobManager log file access
> ------------------------------
>
>                 Key: FLINK-2731
>                 URL: https://issues.apache.org/jira/browse/FLINK-2731
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Webfrontend
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>            Assignee: Sachin Goel
>             Fix For: 0.10
>
>
> Add access to the JobManager log file and out file in the web dashboard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to