tillrohrmann commented on a change in pull request #9832: [FLINK-11843] Bind
lifespan of Dispatcher to leader session
URL: https://github.com/apache/flink/pull/9832#discussion_r337104110
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/DispatcherRunner.java
##########
@@ -30,11 +31,12 @@
public interface DispatcherRunner extends AutoCloseableAsync {
/**
- * Get the currently running {@link Dispatcher}.
+ * Return a future which is completed once the {@link Dispatcher} gains
+ * leadership.
*
- * @return the currently running dispatcher
+ * @return Future which is completed with the leader's gateway
*/
- Dispatcher getDispatcher();
+ CompletableFuture<DispatcherGateway> getDispatcherGateway();
Review comment:
Valid point. I'll try to refactor the tests to get rid of this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
