[ 
https://issues.apache.org/jira/browse/FLINK-14462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956036#comment-16956036
 ] 

Till Rohrmann commented on FLINK-14462:
---------------------------------------

+1 for this removal. This is a good follow up from the Flip-6 work.

Thanks for detailing the potential conflicts [~zhuzh].

> Remove JobGraph#allowQueuedScheduling flag because it is always true
> --------------------------------------------------------------------
>
>                 Key: FLINK-14462
>                 URL: https://issues.apache.org/jira/browse/FLINK-14462
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Configuration
>    Affects Versions: 1.10.0
>            Reporter: Zili Chen
>            Assignee: Zili Chen
>            Priority: Major
>             Fix For: 1.10.0
>
>
> CC [~trohrmann][~zhuzh]
> The only point {{#setAllowQueuedScheduling(false)}} is in 
> {{JobGraphGenerator}}. IIRC we always {{#setAllowQueuedScheduling(true)}} 
> after the generation and before the submission. For reduce confusion I 
> propose to remove {{JobGraph#allowQueuedScheduling}} and refactor the related 
> logic to all respect {{true}}.
> This flag is originally used for configuring different resource allocation 
> strategy between legacy mode and FLIP-6 arch. And there remains branches in 
> {{Scheduler}} which might cause further confusion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to