xuyang1706 commented on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#issuecomment-544495053 > Hi @xuyang1706 thanks for the prompt update. I think overall the patch looks good. > > I only have 2 higher level questions regarding the usage of BLAS (which on a level not only relates to this PR but also related to previously committed codes). Please kindly take a look. Thanks -Rong Thanks for your questions and discuss, @walterddr. It is better to declare our rules for using `F2J_BLAS` and `NATIVE_BLAS`. We have added clear claims in the JavaDoc. Use F2J_BLAS for level-1 routines and NATIVE_BLAS for level-2 and level-3 routines. Regards -Xu
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
