walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336315170
########## File path: flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/linalg/BLASTest.java ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.common.linalg; + +import org.junit.Assert; +import org.junit.Test; + +/** + * The test cases for {@link BLAS}. + */ +public class BLASTest { + private static final double TOL = 1.0e-8; + private DenseMatrix mat = new DenseMatrix(2, 3, new double[]{1, 4, 2, 5, 3, 6}); + private DenseVector dv1 = new DenseVector(new double[]{1, 2}); + private DenseVector dv2 = new DenseVector(new double[]{1, 2, 3}); + private SparseVector spv1 = new SparseVector(2, new int[]{0, 1}, new double[]{1, 2}); + private SparseVector spv2 = new SparseVector(3, new int[]{0, 2}, new double[]{1, 3}); + + @Test + public void testGemvDense() throws Exception { Review comment: missing validator exception test cases: 1. invalid dimension 2. invalid dimension after transpose ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
