dianfu commented on a change in pull request #9890:
[FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#discussion_r336297753
##########
File path: flink-python/pyflink/testing/test_case_utils.py
##########
@@ -149,6 +149,32 @@ def collect(self, table):
return string_result
+class PyFlinkBlinkStreamTableTestCase(PyFlinkTestCase):
+ """
+ Base class for stream unit tests of blink planner.
Review comment:
What about remove the word `unit` as it could also be used in IT cases?
Should also update the comments in other places such as
PyFlinkStreamTableTestCase, PyFlinkBatchTableTestCase,
PyFlinkBlinkBatchTableTestCase, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
