hequn8128 commented on a change in pull request #9894: 
[FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.
URL: https://github.com/apache/flink/pull/9894#discussion_r334453300
 
 

 ##########
 File path: 
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/plan/ExpressionReductionRulesTest.scala
 ##########
 @@ -529,11 +530,13 @@ object DeterministicNullFunc extends ScalarFunction {
   override def isDeterministic = true
 }
 
-object DeterministicPythonFunc extends ScalarFunction {
-
-  override def getLanguage: FunctionLanguage = FunctionLanguage.PYTHON
+object DeterministicPythonFunc extends ScalarFunction with PythonFunction{
 
   def eval(): Long = 1L
 
   override def isDeterministic = true
 
 Review comment:
   Remove the `isDeterministic`. It is true by default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to