hequn8128 commented on a change in pull request #9858: [FLINK-14208][python] 
Optimize Python UDFs with parameters of constant values
URL: https://github.com/apache/flink/pull/9858#discussion_r333997884
 
 

 ##########
 File path: 
flink-python/src/main/java/org/apache/flink/api/common/python/PythonBridgeUtils.java
 ##########
 @@ -70,6 +74,96 @@
                return unpickledData;
        }
 
+       public static byte[] convertLiteralToPython(RexLiteral o, SqlTypeName 
typeName) {
 
 Review comment:
   Add unit tests for this method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to