xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-541029806 > @xuyang1706 Thanks for updating the patch. I left a few more comments. Most of them are minor. One major thing is I am not sure whether we should completely remove `fit(TableEnvironment, Table)` and `transform(TableEnvironment, Table)` API, because they are completely bypassed in the current implementation given the introduction of `MLEnvironmentFactory`. Thanks, @becketqin . I agree with replace `void fit(TableEnvironment, Table)` method with the `MLEnvironmentFactory`, and I suggest we could discuss and change the API in another PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
