hequn8128 commented on a change in pull request #9855: [FLINK-14306][python] Add the code-generated flink_fn_execution_pb2.py to the codebase URL: https://github.com/apache/flink/pull/9855#discussion_r332896778
########## File path: flink-python/README.md ########## @@ -28,3 +28,16 @@ We can enter the directory where this README.md file is located and run test cas ## Python Requirements PyFlink depends on Py4J (currently version 0.10.8.1) and CloudPickle (currently version 1.2.2). + +## Development notices + +Protocol buffer is used in this module and file `flink_fn_execution_pb2.py` is generated from `flink-fn-execution.proto`. Whenever `flink-fn-execution.proto` is updated, please re-generate `flink_fn_execution_pb2.py` by executing + +``` +python pyflink/gen_protos.py +``` + +PyFlink depends on the following libraries to execute the above script: +grpcio-tools (>=1.3.5,<=1.14.2) Review comment: These dependencies will be displayed in one line. Maybe we can format this as: ``` 1. grpcio-tools (>=1.3.5,<=1.14.2) 2. setuptools (>=37.0.0) 3. pip (>=8.0.0) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
