xuyang1706 commented on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate … URL: https://github.com/apache/flink/pull/9355#issuecomment-539809679 > Thanks for the quick response. @xuyang1706. I think I kinda understand what you were trying to achieve now. i think this PR seems to miss lots of context for someone who could perform a successful review (especially with the additional contents like `setPredictionCol` `setFeatureCol` you mentioned in the previous comment). > > How about we merge this one with the first concrete algorithm/model PR together so that it can be better reviewed? Thanks @walterddr, that is good idea. I have submitted another 2 PRs which use OutputColsHelper. [FLINK-13676][ml] Add class of Vector to Columns mapper https://issues.apache.org/jira/browse/FLINK-13676 https://github.com/apache/flink/pull/9413 [FLINK-13835][ml] Add class for FeatureHasherMapper. https://issues.apache.org/jira/browse/FLINK-13835 https://github.com/apache/flink/pull/9523
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
