pnowojski commented on issue #9826: [FLINK-10995][benchmarks] Use BroadcastRecordWriter for network broadcast benchmarks URL: https://github.com/apache/flink/pull/9826#issuecomment-536959908 Yes, I was a bit torn apart by this. I have kept it separated as the `RecordWriterBuilder` was introduced after the benchmark was created. If it was the other way around, it would have been exposed/returned the way I did it in the first commit (in other words, I think this first commit has a value on it's own without adjusting the benchmark). But I could be convinced to squash it if you prefer.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
