[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948461#comment-14948461 ]
ASF GitHub Bot commented on FLINK-1966: --------------------------------------- Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-146493431 Hi @sachingoel0101, Thanks for opening pull request. Great start! I have some comments for your request. 1. Some implementation is not scalaesque. 2. Lack of importing PMML interface I would prefer to cover only PMML interface (`toPMML`, `fromPMML` method) in this pull request. Covering implementation of the PMML interface in other issues would be better for me. > Add support for predictive model markup language (PMML) > ------------------------------------------------------- > > Key: FLINK-1966 > URL: https://issues.apache.org/jira/browse/FLINK-1966 > Project: Flink > Issue Type: Improvement > Components: Machine Learning Library > Reporter: Till Rohrmann > Assignee: Sachin Goel > Priority: Minor > Labels: ML > > The predictive model markup language (PMML) [1] is a widely used language to > describe predictive and descriptive models as well as pre- and > post-processing steps. That way it allows and easy way to export for and > import models from other ML tools. > Resources: > [1] > http://journal.r-project.org/archive/2009-1/RJournal_2009-1_Guazzelli+et+al.pdf -- This message was sent by Atlassian JIRA (v6.3.4#6332)