yanghua commented on a change in pull request #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#discussion_r329662780
########## File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,45 @@ +flink-sql-connector-elasticsearch7 Review comment: > Quite some of the dependencies are test dependencies or transitive dependencies of test dependencies, I don't think they should be added here. Sorry, I do not know we should exclude test dependencies before adding missing dependencied into the notice file. Will remove them when we can decide excluded dependencied list. Besides the license issue, I want to know whether there is any other issue need to be processed? If there is, you can point out so that I can fixed it and at the same time we can wait reply from @twalthr . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
