ex00 commented on a change in pull request #9300: [FLINK-13513][ml] Add the FlatMapper and related classes for later al… URL: https://github.com/apache/flink/pull/9300#discussion_r329508307
########## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/mapper/Mapper.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.common.mapper; + +import org.apache.flink.ml.api.misc.param.Params; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.types.Row; +import org.apache.flink.util.Collector; + +/** + * Abstract class for mappers. + */ +public abstract class Mapper extends FlatMapper implements MapOperable { + + public Mapper(TableSchema dataSchema, Params params) { + super(dataSchema, params); + } + + /** + * This method override the {@link FlatMapper#flatMap(Row, Collector)} to map a row + * to a new row which collected to {@link Collector}. + * + * @param row the input row. + * @param output the output collector + * @throws Exception if {@link Collector#collect(Object)} throws exception. + */ + @Override + public void flatMap(Row row, Collector<Row> output) throws Exception { Review comment: `FlatMapper` can implement `MapOperable` interface, it sounds native, as proof of it we can look to your implementation then all children of `FlatMapper` also implement `MapOperable`. or we can pass mapper as argument to `flatMap` like as in java stream. Anyway the last decision how it will be looks is yours. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
