AHeise commented on a change in pull request #9717: [FLINK-14044] [runtime] 
Reducing synchronization in AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9717#discussion_r328081914
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/execution/MailboxProcessor.java
 ##########
 @@ -200,7 +200,7 @@ private boolean processMail(TaskMailbox mailbox) throws 
MailboxStateException, I
                        try {
                                maybeLetter.get().run();
                        } catch (Exception e) {
-                               e.printStackTrace();
+                               throw new IllegalStateException("Cannot process 
mail " + maybeLetter.get(), e);
 
 Review comment:
   Can we actually use the async exception handler? I stumbled upon that in 
another PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to