[ 
https://issues.apache.org/jira/browse/FLINK-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946685#comment-14946685
 ] 

ASF GitHub Bot commented on FLINK-2785:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1205#discussion_r41377863
  
    --- Diff: docs/libs/gelly_guide.md ---
    @@ -194,6 +194,29 @@ val edgeTuples = env.readCsvFile[String, String, 
Double]("path/to/edge/input")
     
     val graph = Graph.fromTupleDataSet(vertexTuples, edgeTuples, env)
     {% endhighlight %}
    +
    +* from a CSV file of Edge data and an optional CSV file of Vertex data.
    +In this case, Gelly will convert each row from the Edge CSV file to an 
`Edge`, where the first field will be the source ID, the second field will be 
the target ID and the third field (if present) will be the edge value. The 
parameter `readVertices` defines whether vertex data are provided. If 
`readVertices` is set to `true`, then `pathVertices` must be specified. In this 
case, each row from the Vertex CSV file will be converted to a `Vertex`, where 
the first field will be the vertex ID and the second field will be the vertex 
value. If `readVertices` is set to false, then Vertex data will be ignored and 
vertices will be automatically created from the edges input.
    +If the edges have no associated value, set the `hasEdgeValues` parameter 
to `false`.
    --- End diff --
    
    Move this sentence after "... (if present) will be the edge value."?


> Implement Graph's fromCsvReader in Gelly-Scala
> ----------------------------------------------
>
>                 Key: FLINK-2785
>                 URL: https://issues.apache.org/jira/browse/FLINK-2785
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>            Priority: Minor
>
> Graphs's {{fromCsvReader}} method is currently missing from the Gelly Scala 
> API. It cannot be implemented as a simple wrapper over the Java method, 
> because the Java method returns a {{GraphCsvReader}}, which in return creates 
> a Graph after specifying types with appropriate methods. The Scala version of 
> the method can be more nicely implemented using the {{ScalaCsvInputFormat}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to