xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r326013260
########## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/batchoperator/BatchOperator.java ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.batchoperator; + +import org.apache.flink.ml.api.misc.param.Params; +import org.apache.flink.ml.batchoperator.source.TableSourceBatchOp; +import org.apache.flink.ml.common.AlgoOperator; +import org.apache.flink.table.api.Table; +import org.apache.flink.util.Preconditions; + +import java.util.ArrayList; +import java.util.List; + +/** + * Base class of batch algorithm operators. + */ +public abstract class BatchOperator<T extends BatchOperator<T>> extends AlgoOperator<T> { + + public BatchOperator() { + super(); + } + + public BatchOperator(Params params) { + super(params); + } + + public <B extends BatchOperator<?>> B link(B next) { + return linkTo(next); + } + + public <B extends BatchOperator<?>> B linkTo(B next) { + next.linkFrom(this); + return next; + } + + public abstract T linkFrom(BatchOperator<?>... inputs); Review comment: Thanks, added intro and example. For there is no answer area of the above question, I put the answer here: PipelineStage only supports single input and single output, it is the basic unit for pipeline. AlgoOperator supports multi-input and multi-output. We’d like to implement the algorithm with AlgoOperator, and PipelineStage’s fit and transform function can call the AlgoOperator. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
