tillrohrmann commented on a change in pull request #9695: [FLINK-13748][S3][build] Fix jaxb relocation for S3. URL: https://github.com/apache/flink/pull/9695#discussion_r325183483
##########
File path: flink-filesystems/flink-s3-fs-hadoop/pom.xml
##########
@@ -146,6 +141,63 @@ under the License.
<version>2.3.0</version>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+
<groupId>org.apache.maven.plugins</groupId>
+
<artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+
<id>shade-flink</id>
+
<phase>package</phase>
+ <goals>
+
<goal>shade</goal>
+ </goals>
+ <configuration>
+
<shadeTestJar>false</shadeTestJar>
+
<artifactSet>
+
<includes>
+
<include>*:*</include>
+
</includes>
+
</artifactSet>
+
<relocations>
+
<!-- relocate the references to Hadoop to match the shaded Hadoop config -->
+
<relocation>
+
<pattern>org.apache.hadoop</pattern>
+
<shadedPattern>org.apache.flink.fs.shaded.hadoop3.org.apache.hadoop</shadedPattern>
+
</relocation>
+
<!-- relocate the AWS dependencies -->
+
<relocation>
+
<pattern>com.amazon</pattern>
+
<shadedPattern>org.apache.flink.fs.s3base.shaded.com.amazon</shadedPattern>
+
</relocation>
+
+
<!-- relocated S3 hadoop dependencies -->
+
<relocation>
+
<pattern>javax.xml.bind</pattern>
+
<shadedPattern>org.apache.flink.fs.s3hadoop.shaded.javax.xml.bind</shadedPattern>
+
</relocation>
+
<!-- shade Flink's Hadoop FS utility classes -->
+
<relocation>
+
<pattern>org.apache.flink.runtime.util</pattern>
+
<shadedPattern>org.apache.flink.fs.s3hadoop.common</shadedPattern>
+
</relocation>
+
</relocations>
+
<filters>
+
<filter>
+
<artifact>*</artifact>
+
<excludes>
+
<exclude>META-INF/maven/org.apache.flink/force-shading/**</exclude>
+
</excludes>
+
</filter>
+
</filters>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
Review comment:
Instead of adding this rather complicated shade snippet, why don't we always
add the `jaxb-api` dependency via
```
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
<version>2.3.0</version>
</dependency>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
