[ 
https://issues.apache.org/jira/browse/FLINK-13417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931131#comment-16931131
 ] 

TisonKun edited comment on FLINK-13417 at 9/17/19 6:45 AM:
-----------------------------------------------------------

Updates: Manually apply the diff and go through. Maybe there is something 
non-deterministic in {{tools/releasing/collect_license_files.sh}}.

Travis deadlock on {{KafkaTestBase}} because ZK AuthFailed, full log is here 
https://api.travis-ci.org/v3/job/585870154/log.txt

[~StephanEwen] yes I think it is reasonable to shade Flink's ZK as you 
proposed. Otherwise we have to twist our tests quite a bit to let them work. 
I'd like to give it a try to see the effect. However, I'm not so familiar with 
the procedure so here I'd like to describe what I want to do first.

1. create a sub-module {{flink-shaded-zookeeper}} as what we do for 
{{flink-shaded-curator}}. Here I don't know how to generate the NOTICE file.
2. replace {{zookeeper}} dependencies in Flink scope with 
{{flink-shaded-zookeeper}}. Here I don't know whether there is an automatic way 
to list which dependencies should be replaced.


was (Author: tison):
Updates: Manually apply the diff and go through. Maybe there is something 
non-deterministic in {{tools.releasing/collect_license_files.sh}}.

Travis deadlock on {{KafkaTestBase}} because ZK AuthFailed, full log is here 
https://api.travis-ci.org/v3/job/585870154/log.txt

[~StephanEwen] yes I think it is reasonable that shade Flink's ZK as you 
proposed. Otherwise we have to twist our tests quite a bit to let them work. 
I'd like to give it a try to see the effect. However, I'm not so familiar with 
the procedure so here I'd like to describe what I want to do first.

1. create a sub-module {{flink-shaded-zookeeper}} as what we do for 
{{flink-shaded-curator}}. Here I don't know how to generate the NOTICE file.
2. replace {{zookeeper}} dependencies in Flink scope with 
{{flink-shaded-zookeeper}}. Here I don't know whether there is an automatic way 
to list which dependencies should be replaced.

> Bump Zookeeper to 3.5.5
> -----------------------
>
>                 Key: FLINK-13417
>                 URL: https://issues.apache.org/jira/browse/FLINK-13417
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.9.0
>            Reporter: Konstantin Knauf
>            Priority: Major
>             Fix For: 1.10.0
>
>
> User might want to secure their Zookeeper connection via SSL.
> This requires a Zookeeper version >= 3.5.1. We might as well try to bump it 
> to 3.5.5, which is the latest version. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to