[ 
https://issues.apache.org/jira/browse/FLINK-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945216#comment-14945216
 ] 

ASF GitHub Bot commented on FLINK-2479:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1160#discussion_r41280897
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java
 ---
    @@ -498,15 +491,15 @@ public void testBuildSecondWithMixedDataTypes() {
     
        
        
    -   static Map<TestData.Key, Collection<RecordMatch>> matchRecordValues(
    -                   Map<TestData.Key, Collection<TestData.Value>> leftMap,
    -                   Map<TestData.Key, Collection<TestData.Value>> rightMap)
    +   static Map<Integer, Collection<RecordMatch>> matchRecordValues(
    --- End diff --
    
    matchSecondTupleFields


> Refactoring of org.apache.flink.runtime.operators.testutils.TestData class
> --------------------------------------------------------------------------
>
>                 Key: FLINK-2479
>                 URL: https://issues.apache.org/jira/browse/FLINK-2479
>             Project: Flink
>          Issue Type: Task
>          Components: Local Runtime
>            Reporter: Ricky Pogalz
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: pre-apache
>
>
> Currently, there are still tests which use {{Record}} from the old record 
> API. One of the test util classes is {{TestData}}, including {{Generator}} 
> and some other classes still using {{Record}}. An alternative implementation 
> of the {{Generator}} without {{Record}} already exists in the {{TestData}} 
> class, namely {{TupleGenerator}}.
> Please replace the utility classes in {{TestData}} that still use {{Record}} 
> and adapt all of its usages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to