josh0yeh commented on a change in pull request #9587: [FLINK-13685][yarn]
Validate YARN deployment against YARN scheduler maximum vcore size
URL: https://github.com/apache/flink/pull/9587#discussion_r323049833
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -536,12 +538,20 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
protected ClusterSpecification validateClusterResources(
ClusterSpecification clusterSpecification,
int yarnMinAllocationMB,
+ int yarnSchedulerMaxVcores,
Resource maximumResourceCapability,
ClusterResourceDescription freeClusterResources) throws
YarnDeploymentException {
int taskManagerCount =
clusterSpecification.getNumberTaskManagers();
int jobManagerMemoryMb =
clusterSpecification.getMasterMemoryMB();
int taskManagerMemoryMb =
clusterSpecification.getTaskManagerMemoryMB();
+ int slotsPerTaskManager =
clusterSpecification.getSlotsPerTaskManager();
Review comment:
yarn.appmaster.vcores and yarn.containers.vcores are checked in
isReadyForDeployment()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
