AHeise commented on a change in pull request #7942: [FLINK-11696][checkpoint] 
Avoid to send mkdir requests to DFS from task side
URL: https://github.com/apache/flink/pull/7942#discussion_r322593077
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryBackendCheckpointStorage.java
 ##########
 @@ -108,6 +112,12 @@ public boolean supportsHighlyAvailableStorage() {
                return checkpointsDirectory != null;
        }
 
+       @Override
+       public void initializeBaseLocations() {
+               // since 'checkpointDir' which under 'checkpointsDirectory' 
would be created when calling
 
 Review comment:
   +1 for comment
   nit: should be mkdirs instead of mkdir

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to