[ 
https://issues.apache.org/jira/browse/FLINK-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944815#comment-14944815
 ] 

ASF GitHub Bot commented on FLINK-2805:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1227#discussion_r41245655
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -102,8 +161,13 @@ public BlobServer(Configuration config) throws 
IOException {
                        backlog = ConfigConstants.DEFAULT_BLOB_FETCH_BACKLOG;
                }
     
    -           // Add shutdown hook to delete storage directory
    -           this.shutdownHook = BlobUtils.addShutdownHook(this, LOG);
    +           if (recoveryMode == RecoveryMode.STANDALONE) {
    --- End diff --
    
    Yes, sorry the Javadoc is wrong


> Make user jars available for all job managers to recover
> --------------------------------------------------------
>
>                 Key: FLINK-2805
>                 URL: https://issues.apache.org/jira/browse/FLINK-2805
>             Project: Flink
>          Issue Type: Bug
>          Components: BlobManager, JobManager
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>
> This is a bug in https://github.com/apache/flink/pull/1153.
> In case of multiple job managers, the user jars need to be accessible by all 
> job managers (including those who arrive later).
> Since #1153 requires the file state backend to be configured, the simplest 
> solution is to make the blob server aware of the configured recovery mode and 
> put/get/delete the user jars from the file state backend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to