KurtYoung commented on issue #8468: [FLINK-12399][table] Adding PushDownTableSource interface to fix FilterableTableSource applyPredicate problem URL: https://github.com/apache/flink/pull/8468#issuecomment-528232044 Another possible and simple solution might be: 1. we add some more documents to `ProjectableTableSource` and `FilterableTableSource` to let user know he should overwrite `explainSource`, and add required information to the returning string. Like for `ProjectableTableSource`, even if no projection had been pushdown, we should still add some digest to `explainSource` like `projectPushdown=true`, to distinguish with the table source who never tried to push project into it. 2. If #1 is strictly applied, we can add some sanity check in project and filter pushdown rule, to make sure the digest have been changed once the rule has been applied. Letting the program failed at compile stage if he provided a wrong implementation of `ProjectableTableSource` or `FilterableTableSource` .
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
