AHeise commented on a change in pull request #9564: 
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox 
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r320225905
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
 ##########
 @@ -937,19 +894,16 @@ private void 
testTimeoutExceptionHandling(AsyncDataStream.OutputMode outputMode)
         */
        @Test(timeout = 10000)
        public void testRestartWithFullQueue() throws Exception {
-               int capacity = 10;
+               final int capacity = 10;
 
                // 1. create the snapshot which contains capacity + 1 elements
                final CompletableFuture<Void> trigger = new 
CompletableFuture<>();
-               final ControllableAsyncFunction<Integer> 
controllableAsyncFunction = new ControllableAsyncFunction<>(trigger);
-
-               final OneInputStreamOperatorTestHarness<Integer, Integer> 
snapshotHarness = new OneInputStreamOperatorTestHarness<>(
-                       new AsyncWaitOperator<>(
-                               controllableAsyncFunction, // the 
NoOpAsyncFunction is like a blocking function
-                               1000L,
-                               capacity,
-                               AsyncDataStream.OutputMode.ORDERED),
-                       IntSerializer.INSTANCE);
+
+               final OneInputStreamOperatorTestHarness<Integer, Integer> 
snapshotHarness = createTestHarness(
+                       new ControllableAsyncFunction<>(trigger), // the 
NoOpAsyncFunction is like a blocking function
 
 Review comment:
   nit: comment outdated?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to