tillrohrmann commented on a change in pull request #9568: [Flink-12164][tests]
Harden JobMasterTest#testJobFailureWhenTaskExecutorHeartbeatTimeout
URL: https://github.com/apache/flink/pull/9568#discussion_r319577705
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
##########
@@ -95,8 +112,8 @@ ResourceID getOwnResourceID() {
return heartbeatListener;
}
- Collection<HeartbeatMonitor<O>> getHeartbeatTargets() {
- return heartbeatTargets.values();
+ Map<ResourceID, HeartbeatMonitor<O>> getHeartbeatTargets() {
+ return heartbeatTargets;
Review comment:
Instead of changing the return type of this method we could also add a
`Optional<HeartbeatMonitor<O>> getHeartbeatTarget(ResourceID resourceId)`. This
would hide the implementation details a bit better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
