TisonKun commented on a change in pull request #9575: [FLINK-13912][client]
Remove ClusterClient#getClusterConnectionInfo
URL: https://github.com/apache/flink/pull/9575#discussion_r319581155
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -513,12 +509,8 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
yarnApplication,
validClusterSpecification);
- String host = report.getHost();
- int port = report.getRpcPort();
-
- // Correctly initialize the Flink config
- flinkConfiguration.setString(JobManagerOptions.ADDRESS, host);
- flinkConfiguration.setInteger(JobManagerOptions.PORT, port);
Review comment:
This configuration is passed to `RestClusterClient` and never pass to
`ResultStore` IIUC.
An investigation of generally how we configure and use
JM(DispatcherRMComponent) and WebMonitor host&port would be a worthy follow-up.
I don't stick to remove this since it does no harm in production but given its
outputs are only when constructs `RestClusterClient` in
`createYarnClusterClient` we can ensure that it would not escape.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
