AHeise commented on a change in pull request #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator URL: https://github.com/apache/flink/pull/9564#discussion_r319416160
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java ########## @@ -139,8 +130,7 @@ else if (status == STATUS_SHUTDOWN) { // we directly try to register the timer and only react to the status on exception // that way we save unnecessary volatile accesses for each timer try { - return timerService.scheduleAtFixedRate( - new RepeatedTriggerTask(status, task, checkpointLock, callback, nextTimestamp, period), + return timerService.scheduleAtFixedRate(wrapOnTimerCallback(callback, nextTimestamp, period), Review comment: nit: chop ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services