JingsongLi edited a comment on issue #9484: [FLINK-13774][table] Expression DSL use should resolve Expressions in blink URL: https://github.com/apache/flink/pull/9484#issuecomment-525712373 Hi @twalthr @dawidwys , I did three things to delete blink extended expressions: 1.Use `LocalReferenceExpression` to cover `ResolvedAggLocalReference`. 2.Use `RexNodeExpression(RexInputRef)` to cover `ResolvedAggInputReference`. Because now aggregate input use index to find this reference. And now Expression->InputRef do not support use index to InputRef because of the case of grouping keys (The groupings order will be changed by calcite `RelBuilder.aggregate`). So we can not use `FieldReferenceExpression` now. 3.Use `RexNodeExpression` to cover `ResolvedDistinctKeyReference`. Now distinct keys dependents on special logical to generate nullTerm and it is a local variable instead of class member. I think we can use `RexNodeExpression` to wrap RexNode here, because these place are internal codeGen. It did not introduce a new Expression class.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
