[
https://issues.apache.org/jira/browse/FLINK-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915040#comment-16915040
]
Gyula Fora edited comment on FLINK-13832 at 8/24/19 4:46 PM:
-------------------------------------------------------------
I don't mind opening a quick discussion about deprecating this method, but I
don't think Flink would benefit from a FLIP for such a trivial case as it
doesnt break current user code.
There definitely should be a FLIP once we start removing deprecated methods for
Flink 2.0 that should contain this as part of the work, but if we open a FLIP
for every single method that should eventually be renamed for a better API we
will ruin the wiki :D
was (Author: gyfora):
I don't mind opening a quick discussion about deprecating this method, but I
don't think Flink would benefit a Flip for such a trivial case as it doesnt
break current user code.
There definitely should be a FLIP once we start removing deprecated methods for
Flink 2.0 that should contain this as part of the work, but if we open a FLIP
for every single method that should eventually be renamed for a better API we
will ruin the wiki :D
> DefaultRollingPolicy create() method should be renamed to builder()
> -------------------------------------------------------------------
>
> Key: FLINK-13832
> URL: https://issues.apache.org/jira/browse/FLINK-13832
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / FileSystem
> Affects Versions: 1.9.0
> Reporter: Gyula Fora
> Assignee: Gyula Fora
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The DefaultRollingPolicy.create() method returns an instance of
> PolicyBuilder not a DefaultRollingPolicy. Therefore we should add a new
> method named .builder() and deprecate "create".
> Right now if we want to create a new instance with the default settings we
> have to call:
> DefaultRollingPolicy.create().build()
> This nicely illustrates the problem with the naming of this method.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
