HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] 
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r316976653
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ##########
 @@ -746,6 +746,17 @@ public ApplicationReport startAppMaster(
                // ship list that enables reuse of resources for task manager 
containers
                StringBuilder envShipFileList = new StringBuilder();
 
+               int fileReplication = 
yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY, 
DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+               if 
(flinkConfiguration.contains(YarnConfigOptions.FILE_REPLICATION)) {
+                       try {
+                               final String replication = 
flinkConfiguration.getString(YarnConfigOptions.FILE_REPLICATION);
 
 Review comment:
   ConfigOption<Integer> is not nullable. Per your last suggestion, if the 
FILE_REPLICATION is not set, then we will use the default value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to