[
https://issues.apache.org/jira/browse/FLINK-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909081#comment-16909081
]
Piotr Nowojski edited comment on FLINK-13143 at 8/16/19 2:15 PM:
-----------------------------------------------------------------
I think [~yanghua] might be right. Defining a special interface, implementation
class and test class in order to have this code (current):
{code:java}
owner.checkpointExceptionHandler.tryHandleCheckpointException(checkpointMetaData,
checkpointException);
{code}
vs a bit simpler, but referring explicitly to the environment:
{code:java}
owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
checkpointException);
{code}
Seems "a bit" excessive. This should be quite easy change I guess as well.
was (Author: pnowojski):
I think [~yanghua] might be right. Defining a special interface, implementation
class and test class in order to have this code (current):
{code:java}
owner.checkpointExceptionHandler.tryHandleCheckpointException(checkpointMetaData,
checkpointException);
{code}
vs a bit simpler, but referring explicitly to the environment:
{code:java}
owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
checkpointException);
{code}
Seems a bit excessive.
> Refactor CheckpointExceptionHandler relevant classes
> ----------------------------------------------------
>
> Key: FLINK-13143
> URL: https://issues.apache.org/jira/browse/FLINK-13143
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
> Affects Versions: 1.9.0
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
>
> Since FLINK-11662 has been merged, we can clear
> {{CheckpointExceptionHandler}} relevant classes.
> {{CheckpointExceptionHandler}} used to implement
> {{setFailOnCheckpointingErrors}}. Now, it has only one implementation which
> is {{DecliningCheckpointExceptionHandler}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
