bowenli86 opened a new pull request #9457: [FLINK-13741][table] FunctionCatalog.getUserDefinedFunctions() should include Flink built-in functions' names URL: https://github.com/apache/flink/pull/9457 ## What is the purpose of the change FunctionCatalog.getUserDefinedFunctions() only returns catalog functions and FunctionDefinitions registered in memory, but does not include Flink built-in functions' names. It means currently if users call {{tEnv.listUserDefinedFunctions()}} in Table API or {{show functions;}} thru SQL would not be able to see Flink's built-in functions. Should be fixed to include Flink built-in functions' names ## Brief change log - made FunctionCatalog.getUserDefinedFunctions() to include Flink built-in functions' names - dedup function names by replacing list with set in FunctionCatalog.getUserDefinedFunctions() - added unit tests ## Verifying this change This change added tests and can be verified as follows: `FunctionCatalogTest.testGetBuiltInFunctions()` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (JavaDocs)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
