tillrohrmann commented on a change in pull request #9106: [FLINK-13184][yarn]
Support launching task executors with multi-thread on YARN.
URL: https://github.com/apache/flink/pull/9106#discussion_r313568142
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -185,6 +196,12 @@ public YarnResourceManager(
this.resource =
Resource.newInstance(defaultTaskManagerMemoryMB, defaultCpus);
this.slotsPerWorker = createWorkerSlotProfiles(flinkConfig);
+
+ final int containerLauncherNum =
flinkConfig.getInteger(YarnConfigOptions.CONTAINER_LAUNCHER_NUM_MAX);
+ this.startContainerExecutor = new
ThreadPoolExecutor(containerLauncherNum, containerLauncherNum,
Review comment:
I think it would also be better to pass the `ExecutorService` into the
`YarnResourceManager` using dependency injection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
