walterddr commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r312744346
########## File path: flink-ml-parent/flink-ml-lib/src/main/resources/META-INF/licenses/LICENSE.core ########## @@ -0,0 +1,49 @@ +Copyright (c) 2013 Samuel Halliday Review comment: I am not familiar with the naming convention of the license notice. but seems to me `core` is not a very meaningful name of the package we depend on. all other `LICENSE.*` comes with the package short name like `LICENSE.jpython`, `LICENSE.protobuf` ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
