wuchong commented on a change in pull request #9328: [FLINK-13521][sql-client] 
Allow setting configurations in SQL CLI
URL: https://github.com/apache/flink/pull/9328#discussion_r311382377
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
 ##########
 @@ -48,6 +49,8 @@
 
        public static final String EXECUTION_ENTRY = "execution";
 
+       public static final String CONFIGURATION_ENTRY = "table";
 
 Review comment:
   Hi @docete ,  we would like to avoid add a `configuration` prefix when SET 
config options, so that users can have a similar experience with `TableConfig`. 
The `CONFIGURATION_ENTRY` here is used to match configuration key prefix (all 
the existing configuration key are started with `table.exec` or 
`table.optimizer`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to