dianfu commented on a change in pull request #9370: [FLINK-13594][python]
Improve the 'from_element' method of flink python api to apply to blink planner
URL: https://github.com/apache/flink/pull/9370#discussion_r311344959
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/util/python/PythonTableUtils.scala
##########
@@ -422,3 +398,23 @@ object PythonTableUtils {
result
}
}
+
+/**
+ * An InputFormatTableSource created by python 'from_element' method.
+ *
+ * @param inputFormat The input format which contains the python data
collection,
+ * usually created by PythonTableUtils#getInputFormat
method
+ * @param rowTypeInfo The row type info of the python data.
+ * It is generated by the python 'from_element' method.
+ */
+class PythonCollectionInputFormatTableSource[Row](
+ inputFormat: InputFormat[Row, _ <: InputSplit],
Review comment:
Good point. What about rename the class name to
PythonInputFormatTableSource? It allows to change the inputFormat
implementation in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
