Myasuka commented on a change in pull request #9364: 
[FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in 
CheckpointFailureManager
URL: https://github.com/apache/flink/pull/9364#discussion_r311229922
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
 ##########
 @@ -128,7 +128,7 @@
 
        @Before
        public void setUp() throws Exception {
-               failureManager = new CheckpointFailureManager(0, throwable -> 
{});
+               failureManager = new CheckpointFailureManager(0, 
(throwable,attemptID) -> {});
 
 Review comment:
   We should better leave a space between `throwable` and `attemptID`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to