ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310998437
########## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/matrix/DenseMatrix.java ########## @@ -0,0 +1,763 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.common.matrix; + +import java.io.Serializable; +import java.util.Arrays; + +/** + * DenseMatrix stores dense matrix data and provides some methods to operate on + * the matrix it represents. + */ +public class DenseMatrix implements Serializable { + + /** + * Row dimension. + */ + private int m; Review comment: Partly I agree with you, but those fields are private, and for access to it use public methods `numRows` and `numCols` and external Flink developers will be using those methods in any cases. For internal usage in code base more useful and informatory use common practics for developers. Also, we can look to other linear algebra libraries, they use names related with `row` and `columns`: https://github.com/scalanlp/breeze/blob/master/math/src/main/scala/breeze/linalg/DenseMatrix.scala#L53 https://github.com/lessthanoptimal/ejml/blob/SNAPSHOT/main/ejml-core/src/org/ejml/data/DMatrixD1.java#L39 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
