wuchong commented on a change in pull request #9316:
[FLINK-13529][table-planner-blink] Verify and correct agg function's semantic
for Blink planner
URL: https://github.com/apache/flink/pull/9316#discussion_r310489669
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -946,14 +946,9 @@ public SqlMonotonicity getMonotonicity(SqlOperatorBinding
call) {
public static final SqlFirstLastValueAggFunction LAST_VALUE = new
SqlFirstLastValueAggFunction(SqlKind.LAST_VALUE);
/**
- * <code>CONCAT_AGG</code> aggregate function.
+ * <code>LISTAGG</code> aggregate function.
*/
- public static final SqlConcatAggFunction CONCAT_AGG = new
SqlConcatAggFunction();
-
- /**
- * <code>INCR_SUM</code> aggregate function.
- */
- public static final SqlIncrSumAggFunction INCR_SUM = new
SqlIncrSumAggFunction();
+ public static final SqlListAggFunction LISTAGG = new
SqlListAggFunction();
Review comment:
Yes. I agree. Please add a comment on `SqlListAggFunction` why we not use
SqlStdOperatorTable.LISTAGG.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
