[ https://issues.apache.org/jira/browse/FLINK-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935410#comment-14935410 ]
ASF GitHub Bot commented on FLINK-2775: --------------------------------------- Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/1189#discussion_r40695062 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/utils/ExampleUtils.java --- @@ -117,7 +117,7 @@ public void configure(Configuration parameters) { new FlatMapFunction<Long, Edge<Long, NullValue>>() { @Override public void flatMap(Long key, - Collector<Edge<Long, NullValue>> out) + Collector<Edge<Long, NullValue>> out) --- End diff -- Thank! Will update it. > [CLEANUP] Cleanup code as part of theme to be more consistent on Utils classes > ------------------------------------------------------------------------------ > > Key: FLINK-2775 > URL: https://issues.apache.org/jira/browse/FLINK-2775 > Project: Flink > Issue Type: Improvement > Reporter: Henry Saputra > Assignee: Henry Saputra > Priority: Minor > > As part of the theme to help make the code more consistent, add cleanup to > Utils classes: > -) Add final class modifier to the XXXUtils and XXXUtil classes to make sure > can not be extended. > -) Add missing Javadoc header classs to some public classes. > -) Add private constructor to Utils classes to avoid instantiation. > -) Remove unused > test/java/org/apache/flink/test/recordJobs/util/ConfigUtils.java class -- This message was sent by Atlassian JIRA (v6.3.4#6332)