twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r310001855
########## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Fixture.java ########## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeFactory; +import org.apache.calcite.sql.type.SqlTypeName; + +import java.util.List; + +/** + * Type used during tests. + */ +public class Fixture { + private final RelDataTypeFactory typeFactory; + + final RelDataType char1Type; + final RelDataType char33Type; + final RelDataType varcharType; + final RelDataType varchar33Type; + final RelDataType booleanType; + final RelDataType binaryType; + final RelDataType binary33Type; + final RelDataType varbinaryType; + final RelDataType varbinary33Type; + final RelDataType decimalType; + final RelDataType decimalP10S0Type; + final RelDataType decimalP10S3Type; + final RelDataType tinyintType; + final RelDataType smallintType; + final RelDataType intType; + final RelDataType bigintType; + final RelDataType floatType; + final RelDataType doubleType; + final RelDataType dateType; + final RelDataType timeType; + final RelDataType time3Type; + final RelDataType timestampType; + final RelDataType timestamp3Type; + final RelDataType timestampWithLocalTimeZoneType; + final RelDataType timestamp3WithLocalTimeZoneType; + final RelDataType nullType; + + Fixture(RelDataTypeFactory typeFactory) { + this.typeFactory = typeFactory; + this.char1Type = typeFactory.createSqlType(SqlTypeName.CHAR); Review comment: Why? You also don't do it for `binaryType`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
