1u0 commented on issue #9271: [FLINK-13384][1.9][runtime] Fix back pressure sampling for SourceStreamTask URL: https://github.com/apache/flink/pull/9271#issuecomment-517320819 > @1u0 Why is your solution better? Now the `LegacySourceFunctionThread` field can be `final`, and we can always return a non empty `Optional<Thread>` from `SourceStreamTask#getExecutingThread()`. Not being able to access the user class loader in the constructor but in `invoke` is also strange. I assumed that instantiation of `invokable` (StreamTask) has different, more loose contract (not requiring `userCodeClassLoader` set). It's also a little bit misleading that `Task.doRun()` calls `executingThread.setContextClassLoader(userCodeClassLoader)` where in fact the `executingThread == Thread.currentThread()`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
