danny0405 commented on a change in pull request #9212: [FLINK-13338][table-api] 
Sql conformance is hard to config in TableConfig
URL: https://github.com/apache/flink/pull/9212#discussion_r309177333
 
 

 ##########
 File path: flink-python/pyflink/common/sql_dialect.py
 ##########
 @@ -24,19 +24,21 @@ class SqlDialect(object):
     """
     Enumeration of valid SQL compatibility modes.
 
-    For most of the cases, the built-in compatibility mode will suffice. For 
some features,
+    In most of the cases, the built-in compatibility mode will suffice. For 
some features,
     i.e. the "create partitionable table" grammar is only supported in Hive 
dialect, you may need
 
 Review comment:
   For "create partitionable table" i actually mean create a partitionable 
table, it is not really a sql grammar, maybe i should remove the quotes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to