lirui-apache commented on a change in pull request #9264: [FLINK-13192][hive]
Add tests for different Hive table formats
URL: https://github.com/apache/flink/pull/9264#discussion_r309091387
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -494,8 +495,22 @@ private static CatalogBaseTable
instantiateCatalogTable(Table hiveTable) {
String comment = properties.remove(HiveCatalogConfig.COMMENT);
// Table schema
+ List<FieldSchema> fields;
+ if
(org.apache.hadoop.hive.ql.metadata.Table.hasMetastoreBasedSchema(hiveConf,
+
hiveTable.getSd().getSerdeInfo().getSerializationLib())) {
Review comment:
Unfortunately we cannot use `Table.getCols()` because this method gets
HiveConf from SessionState, which we don't possess on Flink side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
