azagrebin commented on issue #9272: [FLINK-13435] Remove ShuffleDescriptor.ReleaseType and make release semantics fixed per partition type URL: https://github.com/apache/flink/pull/9272#issuecomment-516728793 Thanks for the review @zhijiangW ! I will go through the smaller comments. For general concerns: - I think this PR should fit to the overall change we plan with #9250 and FLINK-13476. In #9250 we basically stop using explicitly any notion of 'release on consumption' and assume that blocking partitions always have to be released by JM/TM. FLINK-13476 should also fix it for pipelined bounded until we couple Task finished state with the consumption confirmation attempt, basically with the partition state. Not sure, there are other ways for the direct release internally in netty shuffle service. - FLINK-13478 and FLINK-13493 seem to be independent issues or do I miss something?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
