xuefuz commented on a change in pull request #9279: [FLINK-13423][hive] Unable to find function in hive 1 URL: https://github.com/apache/flink/pull/9279#discussion_r309019671
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV1.java ########## @@ -84,6 +84,7 @@ public Function getFunction(IMetaStoreClient client, String dbName, String funct // hive-1.x doesn't throw NoSuchObjectException if function doesn't exist, instead it throws a MetaException return client.getFunction(dbName, functionName); } catch (MetaException e) { + // need to check the cause and message of this MetaException to decide whether it should actually be a NoSuchObjectException Review comment: Is this specific to HIve 1.2.1? If so, let's be clear, since we didn't have this check previously. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services