dawidwys commented on a change in pull request #9276: [FLINK-13439] Run
Streaming SQL e2e test with blink planner
URL: https://github.com/apache/flink/pull/9276#discussion_r308708830
##########
File path: flink-end-to-end-tests/test-scripts/test_streaming_sql.sh
##########
@@ -21,15 +21,14 @@ source "$(dirname "$0")"/common.sh
TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-stream-sql-test/target/StreamSQLTestProgram.jar
-# copy flink-table jar into lib folder
-add_optional_lib "table"
-
start_cluster
$FLINK_DIR/bin/taskmanager.sh start
$FLINK_DIR/bin/taskmanager.sh start
$FLINK_DIR/bin/taskmanager.sh start
-$FLINK_DIR/bin/flink run -p 4 $TEST_PROGRAM_JAR -outputPath
file://${TEST_DATA_DIR}/out/result
+PLANNER="${1:-old}"
Review comment:
Move the argument definition to the beginning of the file, just as in other
tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
