godfreyhe commented on a change in pull request #9203: [FLINK-13375][table-api]
Improve config names in ExecutionConfigOptions and OptimizerConfigOptions
URL: https://github.com/apache/flink/pull/9203#discussion_r308132095
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -128,80 +123,71 @@
/**
* See {@code
org.apache.flink.table.runtime.operators.window.grouping.HeapWindowsGrouping}.
*/
- public static final ConfigOption<Integer>
SQL_EXEC_WINDOW_AGG_BUFFER_SIZE_LIMIT =
- key("sql.exec.window-agg.buffer-size-limit")
- .defaultValue(100 * 1000)
- .withDescription("Sets the window
elements buffer size limit used in group window agg operator.");
+ public static final ConfigOption<Integer>
TABLE_EXEC_WINDOW_AGG_BUFFER_SIZE_LIMIT =
+ key("table.exec.window-agg.buffer-size-limit")
+ .defaultValue(100 * 1000)
+ .withDescription("Sets the window elements buffer size
limit used in group window agg operator.");
//
------------------------------------------------------------------------
// Async Lookup Options
//
------------------------------------------------------------------------
- public static final ConfigOption<Integer>
SQL_EXEC_LOOKUP_ASYNC_BUFFER_CAPACITY =
- key("sql.exec.lookup.async.buffer-capacity")
- .defaultValue(100)
- .withDescription("The max number of
async i/o operation that the async lookup join can trigger.");
+ public static final ConfigOption<Integer>
TABLE_EXEC_ASYNC_LOOKUP_BUFFER_CAPACITY =
+ key("table.exec.async-lookup.buffer-capacity")
+ .defaultValue(100)
+ .withDescription("The max number of async i/o operation
that the async lookup join can trigger.");
- public static final ConfigOption<String> SQL_EXEC_LOOKUP_ASYNC_TIMEOUT =
- key("sql.exec.lookup.async.timeout")
- .defaultValue("3 min")
- .withDescription("The async timeout for
the asynchronous operation to complete.");
+ public static final ConfigOption<String>
TABLE_EXEC_ASYNC_LOOKUP_TIMEOUT =
+ key("table.exec.async-lookup.timeout")
+ .defaultValue("3 min")
+ .withDescription("The async timeout for the
asynchronous operation to complete.");
//
------------------------------------------------------------------------
// MiniBatch Options
//
------------------------------------------------------------------------
- public static final ConfigOption<Boolean> SQL_EXEC_MINIBATCH_ENABLED =
- key("sql.exec.mini-batch.enabled")
- .defaultValue(false)
- .withDescription("Specifies whether to
enable MiniBatch optimization. " +
- "MiniBatch is an
optimization to buffer input records to reduce state access. " +
- "This is disabled by
default. To enable this, users should set this config to true.");
-
- public static final ConfigOption<String>
SQL_EXEC_MINIBATCH_ALLOW_LATENCY =
- key("sql.exec.mini-batch.allow-latency")
- .defaultValue("-1 ms")
- .withDescription("The maximum latency
can be used for MiniBatch to buffer input records. " +
- "MiniBatch is an
optimization to buffer input records to reduce state access. " +
- "MiniBatch is triggered
with the allowed latency interval and when the maximum number of buffered
records reached. " +
- "NOTE: If " +
SQL_EXEC_MINIBATCH_ENABLED.key() + " is set true, its value must be greater
than zero.");
-
- public static final ConfigOption<Long> SQL_EXEC_MINIBATCH_SIZE =
- key("sql.exec.mini-batch.size")
- .defaultValue(-1L)
- .withDescription("The maximum number of
input records can be buffered for MiniBatch. " +
- "MiniBatch is an
optimization to buffer input records to reduce state access. " +
- "MiniBatch is triggered
with the allowed latency interval and when the maximum number of buffered
records reached. " +
- "NOTE: MiniBatch only
works for non-windowed aggregations currently. If " +
SQL_EXEC_MINIBATCH_ENABLED.key() +
- " is set true, its
value must be positive.");
-
- //
------------------------------------------------------------------------
- // State Options
- //
------------------------------------------------------------------------
- public static final ConfigOption<String> SQL_EXEC_STATE_TTL =
- key("sql.exec.state.ttl")
- .defaultValue("-1 ms")
- .withDescription("Specifies a minimum
time interval for how long idle state " +
- "(i.e. state which was
not updated), will be retained. State will never be " +
- "cleared until it was
idle for less than the minimum time, and will be cleared " +
- "at some time after it
was idle. Default is never clean-up the state.\n" +
- "NOTE: Cleaning up
state requires additional overhead for bookkeeping.");
+ public static final ConfigOption<Boolean> TABLE_EXEC_MINIBATCH_ENABLED =
+ key("table.exec.mini-batch.enabled")
+ .defaultValue(false)
+ .withDescription("Specifies whether to enable MiniBatch
optimization. " +
+ "MiniBatch is an optimization to buffer input
records to reduce state access. " +
+ "This is disabled by default. To enable this,
users should set this config to true. " +
+ "NOTE: If mini-batch is enabled,
'table.exec.mini-batch.allow-latency' and " +
Review comment:
use `TABLE_EXEC_MINIBATCH_ALLOW_LATENCY.key()` instead of
`table.exec.mini-batch.allow-latency` ? and `table.exec.mini-batch.size`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
